Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli 148 #280

Merged
merged 41 commits into from
May 14, 2021
Merged

Cli 148 #280

merged 41 commits into from
May 14, 2021

Conversation

bright-poku
Copy link
Contributor

@bright-poku bright-poku commented May 3, 2021

Description

This Pull request add the following commands:

  • users create
  • users search
  • users show
  • users delete
  • users update

Also, connection API was created which is used for getting connection details.

The current API supports database connections.

Screen Shot 2021-05-04 at 8 27 00 AM

References

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • [X ] The correct base branch is being used, if not master

internal/cli/users.go Outdated Show resolved Hide resolved
internal/auth0/auth0.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
Co-authored-by: Rita Zerrizuela <[email protected]>
@woloski
Copy link

woloski commented May 3, 2021

make sure passwords are masked when creating users

internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
internal/cli/users.go Outdated Show resolved Hide resolved
@Widcket
Copy link
Contributor

Widcket commented May 7, 2021

BTW, everything else is 👍🏼. Thank you for all the hard work!

@bright-poku
Copy link
Contributor Author

@bright-poku testing this, if I pass the password as a flag, it ignores the value and prompts anyway:

Screen Shot 2021-05-07 at 16 42 41

I'd suggest you add some methods to Flag to encapsulate prompting for a password when no value was passed. See https://github.com/auth0/auth0-cli/blob/main/internal/cli/flags.go#L40 as a starting point, and https://github.com/auth0/auth0-cli/blob/main/internal/cli/input.go#L20. Note you'd need a variant for the update method as well (e.g. AskU).

good catch I will look into it. Thanks for the feedback

internal/cli/users.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for all the hard work!

@Widcket Widcket merged commit 83f9ea5 into main May 14, 2021
@Widcket Widcket deleted the CLI-148 branch May 14, 2021 01:57
@Widcket Widcket linked an issue May 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more user management capabilities in the CLI
3 participants